Make analytics storage timing test deterministic

[alfonso-noriega]

WHY are these changes introduced?

The analytics storage unit test used a real setTimeout to create elapsed time before completing a timing. That makes the test slower than necessary and less deterministic.

WHAT is this pull request doing?

Replaces the real timer wait with Vitest fake timers and an explicit system time advance. The test now asserts the exact recorded duration.

How to test your changes?

pnpm --dir packages/cli-kit vitest src/private/node/analytics/storage.test.ts
pnpm --dir packages/cli-kit lint
pnpm --dir packages/cli-kit type-check

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes
• I've considered analytics changes to measure impact
• This change is not user-facing; no changeset is needed.

[alfonso-noriega]

• Make analytics storage timing test deterministic #8091 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.