Precompilation workload - #145
Draft
jd-lara wants to merge 2 commits into
Draft
Conversation
Contributor
|
Performance Results This branch |
odow
reviewed
Jul 29, 2026
| time_steps = get_time_steps(container) | ||
| variables = add_variable_container!( | ||
| container, | ||
| _WorkloadVariable, |
Collaborator
There was a problem hiding this comment.
See one problem with this is that it is precompiling a bunch of methods for _WorkloadVariable, which will never be used in any user's script.
Member
Author
There was a problem hiding this comment.
yeah, we need another strategy here. Perhaps the precompilation workload can use PSY or we can make better methods that can be precompiled correctly with appropriate typing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can precompile certain aspects like the code to create containers without the system.