Skip to content

Updates for removal of deprecated HAL#37

Merged
KenVanHoeylandt merged 6 commits into
mainfrom
app-updates
Jul 26, 2026
Merged

Updates for removal of deprecated HAL#37
KenVanHoeylandt merged 6 commits into
mainfrom
app-updates

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Update all apps to replace deprecated LVGL code and to use the new kernel APIs.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Migrates application LVGL integration to direct LVGL headers and locking APIs. Refactors GraphicsDemo and MystifyDemo display and touch wrappers to use Tactility devices and updated color-format enums. Updates LVGL module lifecycle handling and increments manifest version names and codes across applications.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately reflects the main change: migrating away from deprecated HAL usage to newer APIs.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch app-updates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cb29ed75-1283-4f11-af00-711f9a6fddaf

📥 Commits

Reviewing files that changed from the base of the PR and between 25b966a and 4459b24.

📒 Files selected for processing (12)
  • Apps/Diceware/main/Source/Diceware.cpp
  • Apps/Diceware/manifest.properties
  • Apps/EspNowBridge/main/Source/EspNowBridge.cpp
  • Apps/EspNowBridge/manifest.properties
  • Apps/GPIO/main/Source/Gpio.cpp
  • Apps/GPIO/manifest.properties
  • Apps/MediaKeys/main/Source/MediaKeys.cpp
  • Apps/MediaKeys/manifest.properties
  • Apps/SerialConsole/manifest.properties
  • Apps/Snake/manifest.properties
  • Apps/TwoEleven/manifest.properties
  • Libraries/TactilityCpp/Include/TactilityCpp/LvglLock.h

Comment thread Apps/Diceware/main/Source/Diceware.cpp Outdated
Comment thread Apps/MediaKeys/main/Source/MediaKeys.cpp

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 693af28b-9590-4b64-857d-ba795a13c8d4

📥 Commits

Reviewing files that changed from the base of the PR and between 4459b24 and 104dd74.

📒 Files selected for processing (22)
  • Apps/Breakout/main/Source/Breakout.cpp
  • Apps/Breakout/manifest.properties
  • Apps/Diceware/main/Source/Diceware.cpp
  • Apps/EspNowBridge/main/Source/EspNowBridge.cpp
  • Apps/GPIO/main/Source/Gpio.cpp
  • Apps/GraphicsDemo/main/Include/PixelBuffer.h
  • Apps/GraphicsDemo/main/Include/drivers/DisplayDriver.h
  • Apps/GraphicsDemo/main/Include/drivers/TouchDriver.h
  • Apps/GraphicsDemo/main/Source/Main.cpp
  • Apps/MediaKeys/main/Source/MediaKeys.cpp
  • Apps/MystifyDemo/main/Include/PixelBuffer.h
  • Apps/MystifyDemo/main/Include/drivers/DisplayDriver.h
  • Apps/MystifyDemo/main/Include/drivers/TouchDriver.h
  • Apps/MystifyDemo/main/Source/Main.cpp
  • Apps/MystifyDemo/manifest.properties
  • Apps/SerialConsole/main/Source/ConnectView.h
  • Apps/SerialConsole/main/Source/ConsoleView.h
  • Apps/Snake/main/Source/Snake.cpp
  • Apps/TodoList/main/Source/TodoList.cpp
  • Apps/TodoList/manifest.properties
  • Apps/TwoEleven/main/Source/TwoEleven.cpp
  • Libraries/TactilityCpp/Include/TactilityCpp/LvglLock.h
💤 Files with no reviewable changes (2)
  • Apps/SerialConsole/main/Source/ConsoleView.h
  • Apps/SerialConsole/main/Source/ConnectView.h
🚧 Files skipped from review as they are similar to previous changes (3)
  • Libraries/TactilityCpp/Include/TactilityCpp/LvglLock.h
  • Apps/GPIO/main/Source/Gpio.cpp
  • Apps/MediaKeys/main/Source/MediaKeys.cpp

Comment thread Apps/EspNowBridge/main/Source/EspNowBridge.cpp
@KenVanHoeylandt
KenVanHoeylandt merged commit 4f635d3 into main Jul 26, 2026
21 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the app-updates branch July 26, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant