Updates for removal of deprecated HAL#37
Conversation
📝 WalkthroughWalkthroughMigrates application LVGL integration to direct LVGL headers and locking APIs. Refactors GraphicsDemo and MystifyDemo display and touch wrappers to use Tactility devices and updated color-format enums. Updates LVGL module lifecycle handling and increments manifest version names and codes across applications. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: cb29ed75-1283-4f11-af00-711f9a6fddaf
📒 Files selected for processing (12)
Apps/Diceware/main/Source/Diceware.cppApps/Diceware/manifest.propertiesApps/EspNowBridge/main/Source/EspNowBridge.cppApps/EspNowBridge/manifest.propertiesApps/GPIO/main/Source/Gpio.cppApps/GPIO/manifest.propertiesApps/MediaKeys/main/Source/MediaKeys.cppApps/MediaKeys/manifest.propertiesApps/SerialConsole/manifest.propertiesApps/Snake/manifest.propertiesApps/TwoEleven/manifest.propertiesLibraries/TactilityCpp/Include/TactilityCpp/LvglLock.h
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 693af28b-9590-4b64-857d-ba795a13c8d4
📒 Files selected for processing (22)
Apps/Breakout/main/Source/Breakout.cppApps/Breakout/manifest.propertiesApps/Diceware/main/Source/Diceware.cppApps/EspNowBridge/main/Source/EspNowBridge.cppApps/GPIO/main/Source/Gpio.cppApps/GraphicsDemo/main/Include/PixelBuffer.hApps/GraphicsDemo/main/Include/drivers/DisplayDriver.hApps/GraphicsDemo/main/Include/drivers/TouchDriver.hApps/GraphicsDemo/main/Source/Main.cppApps/MediaKeys/main/Source/MediaKeys.cppApps/MystifyDemo/main/Include/PixelBuffer.hApps/MystifyDemo/main/Include/drivers/DisplayDriver.hApps/MystifyDemo/main/Include/drivers/TouchDriver.hApps/MystifyDemo/main/Source/Main.cppApps/MystifyDemo/manifest.propertiesApps/SerialConsole/main/Source/ConnectView.hApps/SerialConsole/main/Source/ConsoleView.hApps/Snake/main/Source/Snake.cppApps/TodoList/main/Source/TodoList.cppApps/TodoList/manifest.propertiesApps/TwoEleven/main/Source/TwoEleven.cppLibraries/TactilityCpp/Include/TactilityCpp/LvglLock.h
💤 Files with no reviewable changes (2)
- Apps/SerialConsole/main/Source/ConsoleView.h
- Apps/SerialConsole/main/Source/ConnectView.h
🚧 Files skipped from review as they are similar to previous changes (3)
- Libraries/TactilityCpp/Include/TactilityCpp/LvglLock.h
- Apps/GPIO/main/Source/Gpio.cpp
- Apps/MediaKeys/main/Source/MediaKeys.cpp
Update all apps to replace deprecated LVGL code and to use the new kernel APIs.