Sequence IL copy operand translation#8319
Draft
plafosse wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evaluate multi-operand IL subexpressions into locals before constructing the copied expression.
Root cause
LowLevelILInstruction::CopyToinvoked a caller-providedsubExprHandlermultiple times as arguments to the same function call. C++ does not specify the order in which those arguments are evaluated. Stateful handlers, including the core LLIL-to-SSA translator's register-stack tracking callback, could therefore produce compiler-dependent output.Impact
Validation
lowlevelilinstruction.cppwith the development build's C++20 flags using-fsyntax-onlygit diff --checkpassesCompanion core changes are in Vector35/binaryninja#1666.