Pace boomer iterations that exit early#544
Closed
Chuang Wang (chuangw6) wants to merge 1 commit into
Closed
Conversation
iterate() only slept after a full resume/ping/suspend cycle. The early returns -- startUser failing, resume failing -- skipped the wait, and boomer re-enters iterate immediately, so a VU that could not get a worker spun at gRPC round-trip speed. That is exactly backwards from what you want under load. Run more VUs than there are workers and every starved VU hammers ResumeActor at full rate, inflating the reported request counts and adding load to the ateapi that the healthy VUs are waiting on. Move the wait into a defer so every path pays it.
Collaborator
Author
|
Not load-bearing for anything we measured: ResumeActor was 0% fail in every run, so the early-return path never fired. Closing to keep the stack to changes we actually diagnosed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iterate()only slept after a full resume/ping/suspend cycle. The early returns —startUserfailing,resumefailing — skipped the wait, and boomer re-entersiterateimmediately, so a VU that could not get a worker spun at gRPC round-trip speed.That is backwards from what you want under load: run more VUs than there are workers and every starved VU hammers ResumeActor at full rate, inflating the reported request counts and adding load to the ateapi that the healthy VUs are waiting on.
Move the wait into a
deferso every path pays it.Stacked on #543.