Catch LinkageError in addition to ClassNotFoundErrors.#2494
Open
copybara-service[bot] wants to merge 1 commit into
Open
Catch LinkageError in addition to ClassNotFoundErrors.#2494copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
TestRequestBuilder uses Class.forName to load the legacy Suppress annotation and other annotation classes. The call sites currently only catch ClassNotFoundException, but according to the reference docs Class.forName can also throw LinkageError e.g. NoClassDefFoundError. There has been a report of TestRequestBuilder.maybeAddLegacySuppressFilter throwing a fatal NoClassDefFoundError when used with AGP 9.4.0-alpha03. See issuetracker bug 536117227 To make androidx.test.runner more resilient to class loading issues, this commit expands the catch block to also catch Linkage errors PiperOrigin-RevId: 949797644
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch LinkageError in addition to ClassNotFoundErrors.
TestRequestBuilder uses Class.forName to load the legacy
Suppress annotation and other annotation classes.
The call sites currently only catch ClassNotFoundException, but according
to the reference docs Class.forName can also throw LinkageError
e.g. NoClassDefFoundError.
There has been a report of TestRequestBuilder.maybeAddLegacySuppressFilter throwing a fatal NoClassDefFoundError when used with AGP 9.4.0-alpha03. See issuetracker bug 536117227
To make androidx.test.runner more resilient to class loading issues,
this commit expands the catch block to also catch Linkage errors