Fix race condition between table creation and namespace deletion#6476
Open
DomGarguilo wants to merge 1 commit into
Open
Fix race condition between table creation and namespace deletion#6476DomGarguilo wants to merge 1 commit into
DomGarguilo wants to merge 1 commit into
Conversation
phrocker
reviewed
Jul 16, 2026
phrocker
left a comment
phrocker
left a comment
Contributor
There was a problem hiding this comment.
Commenting since I am not a ZK expert and would lean in @DomGarguilo to validate my assertion.
| @Override | ||
| public Repo<FateEnv> call(FateId fateId, FateEnv environment) { | ||
| public Repo<FateEnv> call(FateId fateId, FateEnv environment) throws Exception { | ||
| if (!environment.getContext().getTableMapping(namespaceId).getIdToNameMap().isEmpty()) { |
Contributor
There was a problem hiding this comment.
I could be wrong, but zk will only guarantee the watch event is queued before a subsequent op response, not that the cache has applied it. The window is small I think. Should we do the emptiness check inside a mutateExisting on the mapping node the way we do in TableMapping.put/remove ? that gets you cas rather than read then act?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5389
NamespaceOperationsImpl.delete()checked if a namespace was empty and then submitted the delete FATE op. If another client tried to create a table in that namespace in between the namespace emptiness check and when theDeleteNamespacewas actually executed, the table could still be created and also the namespace deleted.DeleteNamespace.call()itself which happens under a write lock and the race can't happen anymore.NAMESPACE_NOTEMPTYthrift enum so the manager now throwsAcceptableThriftTableOperationExceptionwith that type which the client catches and converts toNamespaceNotEmptyExceptionDeleteNamespacecall on a non-empty namespace to verify the new exception is thrown