fix(catalog): align FileSystemCatalog with Java for object store comp…#532
Open
mlboy wants to merge 5 commits into
Open
fix(catalog): align FileSystemCatalog with Java for object store comp…#532mlboy wants to merge 5 commits into
mlboy wants to merge 5 commits into
Conversation
…atibility - database_exists: append trailing slash so OpenDAL correctly identifies directory paths on OSS/S3 (Hadoop does this via getFileStatus fallback) - table_exists: check schema file presence instead of bare directory existence, mirroring Java's AbstractCatalog.tableExistsInFileSystem - list_tables: filter directories by schema validity and sort results, matching Java's listTablesInFileSystem behavior
QuakeWang
requested changes
Jul 17, 2026
… errors The previous `Err(_) => Ok(false)` swallowed all list_all_ids errors including permission denied and transient storage failures, which could cause create_table to overwrite an existing table's schema. Now only opendal::ErrorKind::NotFound (schema directory missing) maps to Ok(false). All other errors propagate to the caller.
The exact pin =1.13.2 was for upstream Vortex CI stability but conflicts with datafusion 53.x which resolves to 1.13.3.
The fix should be applied downstream in lakeserve instead.
QuakeWang
reviewed
Jul 17, 2026
Cover the previously unverified behaviors: - schema fallback when schema-0 is absent but schema-N exists - markerless directory (no schema/ subdir) returns false - empty schema directory returns false - list_tables filters out invalid directories - non-NotFound errors (e.g. permission denied) are propagated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…atibility
Purpose
Linked issue: close #xxx
Brief change log
Tests
API and Format
Documentation