Propagate serialization failures in Resource.serializeObject() instead of swallowing them#5312
Open
gyowoo1113 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Resource.serializeObject(Object)caught serialization exceptions, printed the stack trace, and still returned aByteBufferfrom the partially written output. When serialization failed, callers could receive truncated or empty data instead of the originalIOException.This PR removes the exception-swallowing catch block and uses try-with-resources for
ObjectOutputStream. Serialization failures now propagate as the already-declaredIOException, allowing the existing caller-side error handling to run and preventing invalid buffers from being returned.A unit test was added with a
Serializableobject that throwsIOExceptionduring serialization. The method signature and behavior for valid serializable objects are unchanged.What type of PR is it?
Bug Fix
Todos
printStackTrace()IOExceptionObjectOutputStreamWhat is the Jira issue?
ZEPPELIN-6467
How should this be tested?
./mvnw test -pl zeppelin-interpreter -Dtest=ResourceTestpasses successfully.To verify that the shaded interpreter JAR includes the change:
./mvnw clean package -pl zeppelin-interpreter,zeppelin-interpreter-shaded -DskipTestspasses successfully.Screenshots (if appropriate)
N/A
Questions: