Auto-initialize hardware flow control for SerialN objects - #549
Open
mbedNoobNinja wants to merge 1 commit into
Open
Auto-initialize hardware flow control for SerialN objects#549mbedNoobNinja wants to merge 1 commit into
mbedNoobNinja wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds automatic hardware flow control initialization for UART
SerialNobjects.Previously, users had to manually construct a
UARTobject to enable RTS/CTS:This is inconvenient because the board variant already defines the RTS and CTS pins.
With this change, calling
automatically enables hardware flow control whenever both RTS and CTS pins are defined for the selected UART in
pins_arduino.h. (I specifically, needed it for this board VK-RA4M2-NANO, on Serial2)This keeps the API simple while preserving the existing behavior for boards that do not define hardware flow control pins.