perf: O(1) else-token lookup in Java analyzer via child(3) instead of find()

[github-actions]

🤖 This pull request was created by Repo Assist, an automated AI assistant.

Summary

Replaces a linear Array.prototype.find() scan with an O(1) indexed child(3) lookup when locating the else keyword in Java if_statement nodes.

What Changed

src/metricsAnalyzer/languages/javaAnalyzer.ts

In Java's tree-sitter AST, an if_statement with an else clause always has this fixed child layout:

Index	Node	Named
0	if keyword	❌
1	condition expression	✅
2	then-body block	✅
3	else keyword	❌
4	else-body	✅

Before: node.children.find((c) => !c.isNamed && c.type === "else")

• Allocates a new closure on every call
• Performs a linear scan of the children array (O(n))
• Only skipped at all when elseBranchNode is null (no else clause)

After: node.child(3) + type guard

• Direct indexed access — O(1), no allocation, no scan
• Defensive type check (elseToken.type === "else") retained for safety

This path runs for every if_statement with an else clause during analysis. In files with many if/else chains, this eliminates repeated closure allocations and scans.

Test Status

npm run compile  ✅  (0 errors)
npm run lint     ✅  (0 warnings)
npm run test:unit  ✅  198 passing, 0 failing

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• releaseassets.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "releaseassets.githubusercontent.com"

See Network Configuration for more information.

Generated by 🌈 Repo Assist, see workflow run. Learn more.
_{Comment /repo-assist to run again}

_{Add this agentic workflow to your repo}

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@1c6668b751c51af8571f01204ceffb19362e0f66

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.43%. Comparing base (a94c59d) to head (961d058).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   81.43%   81.43%           
=======================================
  Files          13       13           
  Lines        4346     4347    +1     
  Branches      440      439    -1     
=======================================
+ Hits         3539     3540    +1     
  Misses        806      806           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR optimizes Java cognitive complexity analysis by replacing a linear scan over if_statement children to locate the else keyword with a direct indexed lookup, reducing per-node overhead during traversal.

Changes:

• Replaced node.children.find(...) with node.child(3) when retrieving the else token for Java if_statement nodes that have an else branch.
• Kept a defensive type check (elseToken.type === "else") before recording the “else clause / else if clause” complexity detail.