Skip to content

Fix placeholder expression assignment ownership - #11698

Open
BenJule wants to merge 1 commit into
bambulab:masterfrom
BenJule:fix/placeholder-parser-move-leak
Open

Fix placeholder expression assignment ownership#11698
BenJule wants to merge 1 commit into
bambulab:masterfrom
BenJule:fix/placeholder-parser-move-leak

Conversation

@BenJule

@BenJule BenJule commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • release existing string storage before copy or move assignment
  • guard both copy and move self-assignment
  • preserve move ownership transfer by marking the source expression empty

Problem

The move-assignment operator overwrote an existing string allocation without releasing it first. The adjacent copy-assignment operator also deleted its own string before reading from the same object during self-assignment.

Validation

  • git diff --check
  • one GPG-signed commit
  • targeted native validation remains delegated to Jenkins

No local full build was performed.

@BenJule
BenJule force-pushed the fix/placeholder-parser-move-leak branch from 4c8c200 to fd88dae Compare July 25, 2026 14:06
@BenJule BenJule changed the title Fix leak in placeholder expression move assignment Fix placeholder expression assignment ownership Jul 25, 2026
@BenJule
BenJule marked this pull request as ready for review July 25, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant