Skip to content

Resolve material types for unknown filament vendors - #11705

Open
BenJule wants to merge 1 commit into
bambulab:masterfrom
BenJule:fix/unknown-vendor-material-fallback
Open

Resolve material types for unknown filament vendors#11705
BenJule wants to merge 1 commit into
bambulab:masterfrom
BenJule:fix/unknown-vendor-material-fallback

Conversation

@BenJule

@BenJule BenJule commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Resolve known material types even when a third-party tray reports a vendor that does not exist in the local preset collection.

Root cause

Material inference restricted candidate types to the reported vendor whenever the vendor string was non-empty. An unknown vendor therefore produced an empty candidate set and prevented otherwise recognizable material strings such as PETG HF from being parsed.

Changes

  • use matching-vendor types when the reported vendor exists
  • fall back to material types from all presets when it does not
  • keep the original reported brand
  • keep single-slot and batch inference behavior aligned

Validation

  • TypeScript project check when local Node dependencies are available
  • git diff --check
  • one GPG-signed commit

No local full build was performed.

@BenJule
BenJule marked this pull request as ready for review July 25, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant