Size calibration speed vectors correctly - #11707
Draft
BenJule wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return correctly sized speed vectors for calibration setup.
Root cause
generate_max_speed_parameter_value()first resized the result vector to its final expected size and then appended the calculated values withemplace_back().The returned vector therefore contained:
The function is used when preparing internal solid infill and top surface speed values for calibration.
Change
Reserve the expected capacity without changing the vector size before appending calculated values.
Validation
Plater.cppcall sitesreserve()and no result-vectorresize()git diff --checkCalibUtils.cppsyntax check when a matching compile database entry is availableNo local full build was performed. Full application validation remains delegated to Jenkins.