Keep calibration delete result alive - #11708
Draft
BenJule wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the selected calibration history result alive for the asynchronous delete callback.
Root cause
The delete button callback captured the range-for variable
resultby reference. The callback runs aftersync_history_data()has returned, so that reference can outlive the loop variable and access invalid state.The neighboring edit callback already captures the same result by value.
Change
Capture
resultby value in the delete callback so every row retains its own stable calibration result.Validation
git diff --checkCaliHistoryDialog.cppsyntax check when a matching compile database entry is availableNo local full build was performed. Full application validation remains delegated to Jenkins.