eos_evpn_multiple_rts: re-sickbay after route-target fixes landed - #226
Merged
Conversation
batfish/batfish#10113 (multiple import/export route-targets) and batfish/batfish#10116 (send-community extended on EVPN neighbors) are fixed on Batfish master, so both cross-VRF routes now reach the main RIB and test_main_rib_routes passes. Drop its sickbay entry. test_bgp_rib_routes and test_evpn_rib_routes still xfail, but only on the pre-existing locally-originated path-attribute divergence (lab-validation#152), not route targets. Re-point their sickbay reasons accordingly. ---- Prompt: ``` Re-triage the eos_evpn_multiple_rts lab against Batfish master now that the route-target fixes have merged, and update the sickbay to match the current pass/fail state. ```
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
=======================================
Coverage 84.39% 84.39%
=======================================
Files 93 93
Lines 4532 4532
=======================================
Hits 3825 3825
Misses 707 707
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
batfish/batfish#10113 (multiple import/export route-targets) and
batfish/batfish#10116 (send-community extended on EVPN neighbors) are
fixed on Batfish master, so both cross-VRF routes now reach the main RIB
and test_main_rib_routes passes. Drop its sickbay entry.
test_bgp_rib_routes and test_evpn_rib_routes still xfail, but only on the
pre-existing locally-originated path-attribute divergence
(lab-validation#152), not route targets. Re-point their sickbay reasons
accordingly.
Prompt: