[codex] Scope huddle rooms by community (BUZZ-SEC-001)#1910
Closed
jmecom wants to merge 0 commit into
Closed
Conversation
jmecom
marked this pull request as ready for review
July 15, 2026 18:02
jmecom
force-pushed
the
codex/fix-buzz-sec-001
branch
2 times, most recently
from
July 15, 2026 22:37
403c744 to
5335eb7
Compare
jmecom
force-pushed
the
codex/fix-buzz-sec-001
branch
from
July 16, 2026 18:34
5335eb7 to
83c90ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Huddle rooms are now keyed by both the authenticated community and channel UUID. Join, cleanup, mesh-control registration, roster resync, and teardown paths all carry that community identity into room lookup.
Legacy mesh audio datagrams do not contain a community identifier. Their lookup now succeeds only when a channel UUID identifies exactly one local room; if the same UUID is active in multiple communities, the datagram is dropped instead of being routed to an arbitrary tenant.
Why
The room registry previously used only the channel UUID as its global key. Two communities can legitimately use the same UUID, so participants and control state from one community could share a room with the other. Cleanup for one tenant could also remove the other tenant's room.
Impact and safety
Normal huddle behavior is unchanged when a channel UUID is unique. Colliding UUIDs now produce separate room, peer, and roster state, and cleanup is limited to the authenticated community.
The legacy datagram fallback deliberately fails closed for an ambiguous UUID. This can drop an in-flight audio packet during a cross-community collision, but it prevents cross-tenant delivery until the media wire format carries community identity.
Testing
cargo test -p buzz-relay audio::room::tests::manager_isolates_identical_channel_ids_between_communitiesThe regression test creates the same channel UUID in two communities, verifies the rooms are distinct, verifies ambiguous legacy lookup fails closed, and verifies cleaning up one community leaves the other room intact.