Persist agent audiences with native inline mentions

[morgmart]

Summary

• adds an opt-in Persistent agent audience desktop setting
• keeps persistent audiences thread-scoped and inherits eligible root mentions only after the root is authoritative
• preserves the exact order agents were explicitly authored in, rather than sorting or normalizing their presentation order
• replaces sent text with retained native mentions immediately, keeps focus at the end, and prevents the mention picker from reopening
• keeps native mention tags as the sole send-routing source and reconciles manual mention deletion

Behavior

When enabled, agents explicitly included in a successful thread send remain as native inline mentions for the next message in that thread. Switching threads restores that thread's own audience. Timeline sends remain one-shot. Ordinary mention-tag routing is unchanged.

Screenshots

Light

Dark

Narrow

Validation

• focused Playwright persistent-audience suite: 7 passed
  • authored-order root inheritance
  • atomic delayed Enter-send transition
  • picker remains closed and caret remains at document end
  • timeline remains one-shot
  • manual native mention removal persists
  • light, dark, and narrow visual coverage
• audience unit tests: 12 passed
• production build and TypeScript typecheck
• Biome formatting and file-size guard

Notes

The local aggregate pre-push hook ran 2,977 desktop tests; 2 source-contract assertions failed because they still expected the removed timeline audience context and the old thread type guard. Those assertions were updated to the intended thread-only contract and the branch was then pushed after the focused behavioral suite, unit tests, build, typecheck, formatting, and file-size guard passed. The mobile hook lane could not run because dart is unavailable in this worktree environment.

[wesbillman]

The persistent-audience product direction looks useful as an opt-in: identity/channel/thread scoping, native mention tags as the routing source, manual-deletion reconciliation, and the generation/revision guards are good safety properties.

One blocking behavior issue remains: Send without inviting removes non-members only from mentionPubkeys, while completeSend later promotes the unchanged draft.explicitAgentPubkeys. For a non-member agent, the send therefore excludes that agent but still persists it; the next composer hydration re-adds it and presents the same invite choice again. This contradicts the user's explicit decision not to route to/invite that recipient. Please filter persistent-audience promotion to the agent pubkeys that remain effective for this completed send, and cover this path with a regression test.

This head is also currently 5 commits behind main, GitHub reports merge conflicts (including useMentions.ts and playwright.config.ts), and only DCO/Semgrep/zizmor ran. Please rebase, resolve the overlap, and obtain fresh full desktop CI before approval.

[morgmart]

Addressed the blocking review and rebased onto current main in 8a2cd671:

• Send without inviting now filters persistent-audience promotion against the recipients that remain effective for the completed send, so an excluded non-member agent is neither routed nor rehydrated afterward.
• Added regression coverage for excluding removed agents while preserving authored order/deduplication.
• Resolved the playwright.config.ts conflict by retaining both the new mainline team-mentions suite and this PR’s persistent-audience suite.
• Resolved the useMentions.ts overlap by retaining mainline team mention insertion and adding the native resolved-mention API used for hydration.

Focused validation passed: 14 audience/send tests, TypeScript typecheck, Biome, and diff checks. GitHub now reports the PR mergeable and fresh full CI is queued.

[morgmart]

Fixed the Desktop Core failure in 1c1a98e5. The rebase brought useMentions.ts to 1,001 measured lines, one above the 1,000-line guard. I consolidated the duplicated case-insensitive unique-name state update into a small helper, bringing the file to 992 physical lines without adding an override or changing behavior.

Local validation: pnpm check:file-sizes, focused Biome, TypeScript typecheck, diff check, and all 14 focused audience/send tests pass. Fresh CI is starting for the new head.

[wesbillman]

Re-reviewed the latest head. The blocking Send without inviting issue is fixed by intersecting explicitly authored agents with the effective mention recipients before promotion, with focused regression coverage. The authored-order behavior remains intact, the branch is mergeable, and full desktop CI is green. I found no remaining behavior blocker.