Skip to content

fix(onboarding): add Welcome finalize skip escape hatch#1960

Merged
wesbillman merged 1 commit into
mainfrom
pinky/community-onboarding-finalize-skip
Jul 16, 2026
Merged

fix(onboarding): add Welcome finalize skip escape hatch#1960
wesbillman merged 1 commit into
mainfrom
pinky/community-onboarding-finalize-skip

Conversation

@wesbillman

Copy link
Copy Markdown
Collaborator

Summary

  • relabel the existing Welcome-creation failure escape hatch as Skip for now
  • preserve retry as the primary action
  • verify skipping marks relay/pubkey onboarding complete, clears the persisted transaction, and enters the joined community without creating Welcome

Test plan

  • cd desktop && pnpm build
  • cd desktop && pnpm exec playwright test tests/e2e/deep-link-invite.spec.ts --project=smoke (4 passed)
  • just desktop-fix (format/file-size checks pass; reports two pre-existing unrelated unused-symbol warnings)

Cover the failed Welcome creation path through completion and transaction cleanup.

Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
@wesbillman
wesbillman requested a review from a team as a code owner July 16, 2026 15:20
@wesbillman
wesbillman merged commit 7ed6422 into main Jul 16, 2026
25 checks passed
@wesbillman
wesbillman deleted the pinky/community-onboarding-finalize-skip branch July 16, 2026 15:52
tlongwell-block pushed a commit that referenced this pull request Jul 16, 2026
* origin/main: (29 commits)
  chore(release): release Buzz Mobile version 0.4.5 (#1965)
  fix(mobile): support open pairing relays (#1939)
  feat(desktop): refine Projects navigation and overview hierarchy (#1956)
  Log handoff token counts (#1954)
  fix(onboarding): add Welcome finalize skip escape hatch (#1960)
  Welcome channel: Browse channels card, browser sorting, shortcut hint placement (#1948)
  chore(release): release Buzz Desktop version 0.4.7 (#1955)
  feat(desktop): confirm invites with an Opening-invite loading gate before machine onboarding (#1950)
  fix(mobile): replace pairing placeholder with Buzz icon (#1952)
  feat(desktop): remove theme selection from onboarding, default to Buzz + System (#1947)
  fix(desktop): sentence-case runtime descriptions in onboarding setup (#1944)
  feat(desktop): Projects v3 — overview redesign, activity feed, agent access & sync controls (#1851)
  Rework first-launch community onboarding (#1936)
  fix(desktop): stop marking users away while active on the machine (#1942)
  Add pre-push branch-skew guard and changed-spec e2e recipe (#1940)
  ci: build the relay once and cache it by source hash (#1941)
  fix(desktop): variant-aware connecting gate for first-run handoffs (#1938)
  Redesign agent AI configuration and defaults (#1935)
  Add Buzz-managed Node runtime for agent installs (#1930)
  feat(desktop): return nostr binding proof in browser fragment (#1933)
  ...

# Conflicts:
#	desktop/src/features/communities/ui/AddCommunityDialog.tsx
#	desktop/src/features/communities/ui/WelcomeSetup.tsx
#	desktop/src/features/onboarding/ui/MembershipDenied.tsx
#	desktop/src/shared/deep-link.ts
#	desktop/tests/e2e/onboarding.spec.ts
tlongwell-block pushed a commit that referenced this pull request Jul 16, 2026
* origin/main: (29 commits)
  chore(release): release Buzz Mobile version 0.4.5 (#1965)
  fix(mobile): support open pairing relays (#1939)
  feat(desktop): refine Projects navigation and overview hierarchy (#1956)
  Log handoff token counts (#1954)
  fix(onboarding): add Welcome finalize skip escape hatch (#1960)
  Welcome channel: Browse channels card, browser sorting, shortcut hint placement (#1948)
  chore(release): release Buzz Desktop version 0.4.7 (#1955)
  feat(desktop): confirm invites with an Opening-invite loading gate before machine onboarding (#1950)
  fix(mobile): replace pairing placeholder with Buzz icon (#1952)
  feat(desktop): remove theme selection from onboarding, default to Buzz + System (#1947)
  fix(desktop): sentence-case runtime descriptions in onboarding setup (#1944)
  feat(desktop): Projects v3 — overview redesign, activity feed, agent access & sync controls (#1851)
  Rework first-launch community onboarding (#1936)
  fix(desktop): stop marking users away while active on the machine (#1942)
  Add pre-push branch-skew guard and changed-spec e2e recipe (#1940)
  ci: build the relay once and cache it by source hash (#1941)
  fix(desktop): variant-aware connecting gate for first-run handoffs (#1938)
  Redesign agent AI configuration and defaults (#1935)
  Add Buzz-managed Node runtime for agent installs (#1930)
  feat(desktop): return nostr binding proof in browser fragment (#1933)
  ...

# Conflicts:
#	desktop/src/features/communities/ui/AddCommunityDialog.tsx
#	desktop/src/features/communities/ui/WelcomeSetup.tsx
#	desktop/src/features/onboarding/ui/MembershipDenied.tsx
#	desktop/src/shared/deep-link.ts
#	desktop/tests/e2e/onboarding.spec.ts

Signed-off-by: npub12gtutshhh76rx0jx697f32f9tffd4hhp3hx58fp4x6u4uemkm7sqf8f757 <5217c5c2f7bfb4333e46d17c98a9255a52dadee18dcd43a43536b95e6776dfa0@sprout-oss.stage.blox.sqprod.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant