fix: paginate cluster secret list so all secrets are returned#906
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix: paginate cluster secret list so all secrets are returned#906AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
bk secret listonly ever returned the first page of cluster secrets (up to 30), with no way to fetch the rest. With more than 30 secrets in a cluster the remaining ones were silently dropped from the output.Changes
cmd/secret/list.gonow loops theClusterSecrets.Listcall usingClusterSecretsListOptionswithPerPage: 100, followingResponse.NextPageuntil it is zero, accumulating every page.TestListSecretsPaginatestocmd/secret/secret_test.goto assert that a two-page response (Link rel=next) yields all 50 secrets.Testing
go test ./cmd/secret/)go fmt ./...)