Skip to content

Add job step and group key filter flags#915

Open
mitchbne wants to merge 2 commits into
mainfrom
mitch/add-job-key-filter-flags
Open

Add job step and group key filter flags#915
mitchbne wants to merge 2 commits into
mainfrom
mitch/add-job-key-filter-flags

Conversation

@mitchbne

@mitchbne mitchbne commented Jul 17, 2026

Copy link
Copy Markdown
Member

Description

Adds --step-key and --group-key server-side filters to bk job list --build. Both filters can be combined, require --build, and are preserved across cursor pages.

This PR uses the support from go-buildkite #347, released in v5.7.0.

Deployment order:

  1. Confirm the server-side filters are deployed.
  2. Merge this CLI change.

Dependent documentation should publish only after these CLI flags ship.

Testing

  • Focused job command tests pass locally (go test ./cmd/job)
  • Code is formatted (gofmt via the pre-commit hook)
  • Lint passes (golangci-lint via the pre-commit hook)
  • Full suite locally hit the unrelated TestSnapshotContext_CancelsPush timing flake; the test passed three isolated runs

Rollback

Revert this PR. The flags are additive and do not change persisted data.

Disclosures / Credits

Amp implemented the tests and CLI changes under human direction.

@socket-security

socket-security Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgithub.com/​buildkite/​go-buildkite/​v5@​v5.3.1 ⏵ v5.7.072 +1100100100100

View full report

@mitchbne
mitchbne marked this pull request as ready for review July 17, 2026 06:52
@mitchbne
mitchbne requested review from a team as code owners July 17, 2026 06:52
@mitchbne mitchbne self-assigned this Jul 17, 2026
@mitchbne

Copy link
Copy Markdown
Member Author

@buildsworth-bk feel free to approve something up to and including L2

@buildsworth-bk-app buildsworth-bk-app Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find any issues. I'm leaving this as a comment rather than an approval because the change adds new server-backed CLI filtering behaviour, which puts it above the default AI approval ceiling.

Want to dig deeper?

The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:

Download the buildsworth logs from build 5938, then answer my questions about the findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant