Add job step and group key filter flags#915
Open
mitchbne wants to merge 2 commits into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This was referenced Jul 17, 2026
Member
Author
|
@buildsworth-bk feel free to approve something up to and including L2 |
Contributor
There was a problem hiding this comment.
I didn't find any issues. I'm leaving this as a comment rather than an approval because the change adds new server-backed CLI filtering behaviour, which puts it above the default AI approval ceiling.
Want to dig deeper?
The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:
Download the buildsworth logs from build 5938, then answer my questions about the findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
--step-keyand--group-keyserver-side filters tobk job list --build. Both filters can be combined, require--build, and are preserved across cursor pages.This PR uses the support from go-buildkite #347, released in v5.7.0.
Deployment order:
Dependent documentation should publish only after these CLI flags ship.
Testing
go test ./cmd/job)gofmtvia the pre-commit hook)golangci-lintvia the pre-commit hook)TestSnapshotContext_CancelsPushtiming flake; the test passed three isolated runsRollback
Revert this PR. The flags are additive and do not change persisted data.
Disclosures / Credits
Amp implemented the tests and CLI changes under human direction.