Python tooling shouldn't look at pyproject.toml outside the repository#141
Merged
Conversation
ReinierMaas
force-pushed
the
reinier/contain-python-tooling
branch
from
July 17, 2026 11:50
1213a8f to
ac3b210
Compare
There was a problem hiding this comment.
Pull request overview
Adds repository-root Python tooling configuration to prevent tools (notably ruff) from walking up the directory tree and accidentally picking up a parent pyproject.toml, while also updating Nix pins and aligning some Python version settings.
Changes:
- Add
ruff.tomland a rootpyproject.tomlintended to anchor Python tooling configuration within the repo. - Update the pinned
nixpkgsrevision/sha and minor Nix overlay formatting. - Adjust Nix-based integration test recipe wiring and bump Python version expectations in a few places.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ruff.toml | Adds repo-root Ruff configuration to prevent config discovery outside the repo. |
| pyproject.toml | Adds repo-root pyproject intended to anchor Python tooling config. |
| nix/sources.json | Updates pinned nixpkgs revision and checksum. |
| nix/overlay.nix | Removes trailing whitespace in overlay. |
| libs/opsqueue_python/pyproject.toml | Raises the Python client library’s declared minimum Python version. |
| justfile | Changes nix-test-integration prerequisite from nix-build-bin to nix-build. |
| extra/experimentation/shell.nix | Updates experimental shell to use Python 3.13. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@OpsBotPrime merge! |
… the repository Approved-by: ReinierMaas Priority: Normal Auto-deploy: false
Contributor
|
Rebased as 229abca, waiting for CI … |
Contributor
|
CI job 🟡 started. |
OpsBotPrime
force-pushed
the
reinier/contain-python-tooling
branch
from
July 21, 2026 10:28
fecc0cc to
229abca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents ruff from depending on the
./pyproject.tomlof a folder containing the Opsqueue checkout.