feat(chat): type-aware DM feed (CONTACT_DM / TIP_DM)#1110
Merged
Conversation
Adds the client wrapper for the BlobStorage gRPC service (direct-to-storage presigned uploads): Api/Service/Repository/Controller, an HTTP BlobUploader, the UploadTarget/UploadPolicy domain models + proto converters, error types, and DI wiring. BlobStorageController.upload() coordinates the full handshake (reserve -> PUT/POST -> complete -> poll until READY) behind one call, and getUploadPolicy() exposes the accepted MIME/size constraints. Covered by UploadPolicyTest and BlobStorageControllerTest. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
Makes the shared chat FeedOperations type-aware: feed(chatType) and observeUnreadConversations(chatType) now take a required ChatType, and the sync delegate merges the CONTACT_DM and TIP_DM feeds while only applying the contact identity-drop to CONTACT_DM. Send flow consumes feed(CONTACT_DM); the contact list carries a ConversationReference instead of a raw Conversation. Session/nav rename the generic notificationUnreadCount to contactDmUnreadCount now that unread is tracked per chat type. Covered by FeedSyncCombinedFeedTest. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
github-actions
Bot
added
type: feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR 2/5 — base:
feat/blob-storage-services(#1109)Makes the shared chat feed aware of DM type so contact DMs and tip DMs can be tracked separately.
What
FeedOperations.feed(chatType)andobserveUnreadConversations(chatType)now take a requiredChatType.FeedSyncDelegatemerges the CONTACT_DM and TIP_DM feeds; the contact identity-drop is applied only to CONTACT_DM.feed(ChatType.CONTACT_DM); the contact list now carries aConversationReferenceinstead of a rawConversation.notificationUnreadCount→contactDmUnreadCountnow that unread is per-type.Tests
FeedSyncCombinedFeedTest.