fix(timeseries): prevent duplicate dataset creation race condition - #1868
Open
sentry[bot] wants to merge 1 commit into
Open
fix(timeseries): prevent duplicate dataset creation race condition#1868sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
GraphQLError: duplicate key value violates unique constraint "name_repository_id_unique"(API-ES8).Problem:
When multiple concurrent GraphQL requests, specifically
GetReposCoverageMeasurements, attempt to fetch coverage measurements for an owner, a race condition can occur. Theowner_coverage_measurements_with_fallbackfunction identifiestimeseries_datasetentries that are missing for certain repositories and then attempts to create them usingDataset.objects.bulk_create.Root Cause:
If two or more requests simultaneously identify the same set of missing datasets and proceed to
bulk_create, the second (or subsequent)bulk_createoperation will attempt to insert rows that already exist, leading to aUniqueViolation(IntegrityError) on thename_repository_id_uniqueconstraint.Solution:
Added
ignore_conflicts=Trueto theDataset.objects.bulk_createcall intimeseries/helpers.py. This leverages PostgreSQL'sON CONFLICT DO NOTHINGbehavior, allowing concurrent inserts to proceed without error if a row with the same unique key already exists. This effectively resolves the race condition.Impact on
trigger_backfill:Confirmed that
trigger_backfillgracefully handles an empty list ofcreated_datasets(which can occur if all datasets were created by a racing process andignore_conflicts=Truewas used), ensuring no further issues.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes API-ES8