fix(upload): prevent Commit.DoesNotExist during upload serialization - #1870
Open
sentry[bot] wants to merge 1 commit into
Open
fix(upload): prevent Commit.DoesNotExist during upload serialization#1870sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (80.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1870 +/- ##
==========================================
- Coverage 91.83% 91.83% -0.01%
==========================================
Files 1332 1332
Lines 51830 51838 +8
Branches 1647 1647
==========================================
+ Hits 47598 47604 +6
- Misses 3911 3913 +2
Partials 321 321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
Commit.DoesNotExisterror occurring in the/upload/{service}/{repo}/commits/{commit_sha}/reports/{report_code}/uploadsendpoint during response serialization.Root Cause:
The
UploadSerializer.get_url()method was attempting to accessobj.report.commit.repositorywhich triggered a fresh database lookup for theCommitobject via its foreign key. A race condition could occur where theCommitobject, which was successfully retrieved earlier in the request byget_commit(), was concurrently deleted from the database (e.g., by a background task or another request) beforeget_url()executed. Sinceget_url()had no exception handling forDoesNotExist, this led to an unhandled crash.Solution:
UploadViews.perform_create(), the already-fetchedcommitandrepositoryobjects are now passed into theUploadSerializer's context beforecreate_upload()is called. This ensures these objects are available during serialization.get_url(): TheUploadSerializer.get_url()method has been updated to first attempt to retrieve thecommitandrepositoryfromself.context. This avoids the problematic fresh database lookup.try-exceptblock has been added toget_url()as a fallback. If thecommitorrepositoryare not found in the context (e.g., ifget_url()is called in a different flow) or if the FK lookup still fails, it will now catch any exception and return an empty string, preventing an unhandled error.This change eliminates the race condition, improves efficiency by avoiding redundant database queries, and makes the upload serialization process more robust.
Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes API-ESG