fix(graphql): Add changeCode field to ComponentComparison and FlagComparison - #1874
Open
sentry[bot] wants to merge 1 commit into
Open
fix(graphql): Add changeCode field to ComponentComparison and FlagComparison#1874sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1874 +/- ##
==========================================
- Coverage 91.83% 91.80% -0.04%
==========================================
Files 1332 1332
Lines 51830 51852 +22
Branches 1647 1647
==========================================
+ Hits 47598 47602 +4
- Misses 3911 3929 +18
Partials 321 321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue API-ESK, a
GraphQLError: Cannot query field 'changeCode' on type 'ComponentComparison'.The root cause was that the
changeCodefield was being queried by a client but was not defined in the GraphQL schema for eitherComponentComparisonorFlagComparisontypes, nor was it implemented in their respective resolvers.To fix this, the
changeCode: Floatfield has been added to:apps/codecov-api/graphql_api/types/component_comparison/component_comparison.graphqlapps/codecov-api/graphql_api/types/flag_comparison/flag_comparison.graphqlCorresponding resolvers have been implemented in:
apps/codecov-api/graphql_api/types/component_comparison/component_comparison.pyapps/codecov-api/graphql_api/types/flag_comparison/flag_comparison.pyThese resolvers calculate
changeCodeas the difference betweenhead_totals.coverageandbase_totals.coverage, returningNoneif either total or their coverage values are unavailable. While a similar concept exists aschangeCoverageon theComparisontype,changeCodewas used here to directly match the field name requested by the client query.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes API-ESK