[CCOR-13193] Run Integration(e2e) tests on PR-to-main (phase 1: test with sdkdev v5 server)#422
Open
chrishagglund-ship-it wants to merge 25 commits into
Open
[CCOR-13193] Run Integration(e2e) tests on PR-to-main (phase 1: test with sdkdev v5 server)#422chrishagglund-ship-it wants to merge 25 commits into
chrishagglund-ship-it wants to merge 25 commits into
Conversation
Codecov Report❌ Patch coverage is
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
a8c5414 to
75d1a72
Compare
…ion (try/finally instead of try/catch/reraise)
…e task when it feels like it, not on our timeline
…e but we can poll for that
1d044e7 to
eca4986
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables the integration test suite to run in CI on pull requests and hardens the
suite to run reliably against the shared
sdkdevdev server. Introduces a sharedretry/poll helper module, splits the slowest tests into parallel CI buckets, and
fixes a number of latent test bugs surfaced by actually running these tests in CI.
Production code impact is limited to two small, backward-compatible model additions.
Changes
CI
integration-testjob topull_request.ymlrunning four parallel buckets(
test-all,long-sync,long-async,core) via a matrix, with a 30-min timeout.pull_request/pushtomain(plusworkflow_dispatch); scope theconcurrency group by
head_refso PR runs cancel their own in-progress runs.CONDUCTOR_HTTP2_ENABLED=false) to avoidintermittent mid-stream HTTP/2 stalls through the shared server's proxy/LB.
no longer request server secrets (they run offline).
Test infrastructure
tests/integration/retry_helpers.py: the single home for transient-blipdetection (
is_transient), per-request retry (retry_on_transient,retry_on_status), scenario-level retry with a shared wall-clock deadline(
retry_scenario), and a shared poll-to-terminal primitive(
wait_for_workflow_terminal).scripts/run_integration_tests.shto run the suite locally, mirroring the CIbuckets (AI/agentic and perf tests excluded by default;
--bucket=/--with-perf).slow_sync,slow_async,slow_test_all,server_timeout_unreliable) inpyproject.tomlto drive bucket selection.Reliability fixes in tests
server don't steal or strand each other's tasks.
TaskHandlerstopped intearDownClass(replacing a daemon thread + fixed
sleep(90)that could hang the interpreterat exit), and assert each expected worker is discovered and alive.
add server-side diagnostics (queue sizes, pollers, worker liveness) on give-up.
WorkflowScheduleas an object not a dict; drain theshared task queue by each polled task's own workflow id/ref; add a missing
asserton task logs; correct an access-key-lookup assertion.
test_*scenario helpers that take aworkflow_executorarg toscenario_*so pytest stops mis-collecting them as standalone tests.
Models (backward-compatible)
UpsertUserRequest: add optionalcontact_information: Dict[str, str]field.ServiceMethod.example_input:dict->object.Risk
existing backward-compatibility and serde tests.
Notes for reviewers
main(previously all PRs). Confirm this matchesthe branching model.
server_timeout_unreliableno-heartbeat timeout cases are excluded from CIbuckets (the dev server doesn't fire the timeout on a CI-bounded timeline); the
SDK heartbeat-keeps-alive path is still covered.