refactor(misc): drop services_public from graphile plugin docs, compose files, csv-to-pg test#1445
Open
pyramation wants to merge 3 commits into
Open
refactor(misc): drop services_public from graphile plugin docs, compose files, csv-to-pg test#1445pyramation wants to merge 3 commits into
pyramation wants to merge 3 commits into
Conversation
…ures, compose files
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Miscellaneous slice of the hard migration off
services_public. Thejobs/knative-job-servicemigration that was originally here has been reverted tomain— it must land together with the server-default flip in the core PR #1447, which now owns it.chat.ts,embedder.ts,plugins/llm-module-plugin.ts,types.ts,README.md): doc references to thellm_modulesource table now sayconstructive_routing_public.api_modules. No code path names the schema._schemaPrefixdoc example →constructive_routing_public_api -> constructiveRoutingPublicApi; the inflector itself already returns''for every schema.API_EXPOSED_SCHEMAS→metaschema_public,constructive_routing_public,constructive_auth_public;API_META_SCHEMASadditionally gets catalog + apps. Routing alone is exposed on purpose: exposing catalog and routing together trips PostGraphile withAttempted to add a second codec named 'apis', since the custom inflector strips schema prefixes and both schemas have anapistable.services_publicwas only an arbitrary example schema name inexport.test.ts; renamed toapp_publicwith snapshots re-recorded.Not changed:
__fixtures__/output/**is generated codegen output that still containsschemas/services_public.ts— it belongs to the codegen regeneration follow-up, not a hand edit.Link to Devin session: https://app.devin.ai/sessions/33ae06cfdc414ea7b15c9795abc0dcb3
Requested by: @pyramation