fix: detect parsePlPgSQL errors by non-JSON result instead of message prefix#162
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wasm_parse_plpgsqlreturns error messages as plain strings, but the JS side only recognized errors prefixed withsyntax error/deparse error/ERROR. Any other PostgreSQL error message (e.g.RETURN cannot have a parameter in function with OUT parameters,"x" is not a known variable) fell through toJSON.parseand surfaced as a confusingUnexpected token 'R', "RETURN can"... is not valid JSONSyntaxError, swallowing the real message.Since a successful parse always returns a JSON object (
{"plpgsql_funcs":...}),parsePlPgSQL/parsePlPgSQLSyncnow treat any result not starting with{as an error:Changed in
templates/full/index.ts(source of truth) and the generatedversions/18/src/index.ts. This was issue #1 in the earlier libpg-query@18.1.0 PL/pgSQL bug report;fingerprint/normalizekeep their prefix checks since their success values are plain strings.Link to Devin session: https://app.devin.ai/sessions/064ad193e1c040af8c145d55e07af9b8
Requested by: @pyramation