feat: sync modules from constructive-db (services removed, catalog/routing module tables added)#104
Merged
Merged
Conversation
Remove services module; add catalog/domain/api_surface/site_surface/route/app/database_settings module tables and metaschema exclusion_constraint.
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…formation_schema cross-product
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstreams
constructive-db/pgpm-modules/*intopackages/*with constructive-db as source of truth. Only source content (deploy/,verify/,revert/,pgpm.plan,__tests__/) was synced — versions,Makefile/.controldefault_version, and generatedsql/bundles were intentionally left untouched (see follow-up).servicesremoved. The services → scoped-routing cutover deleted the module in constructive-db, sopackages/services/is gone, along with the orphanedservices_public/services_privateverify/+revert/trees still sitting inmetaschema-schemaandmetaschema-modules. Knock-on edits:plus the
servicesentry in the CI matrix,README.md/MODULES.md, and its lockfile importer.metaschema-modulesgains the typed catalog/routing config tables (deploy+verify+revert+plan):catalog_module,domain_module,api_surface_module,site_surface_module,route_module,app_module,database_settings_module; ~30 existing*_module/table.sqlfiles picked up their constructive-db edits. Snapshots regenerated (58 → 65module tables).metaschema-schemagainsexclusion_constraint(EXCLUDE constraints) and syncscheck_constraint,field,foreign_key_constraint,primary_key_constraint,unique_constraint,view.app-scopeframes()now resolves the platform database lazily instead of viaapp_scope.platform_database_id()inside the walk: with nometaschema_public.database WHERE platformrow (generation bootstrap / isolated metaschemas) the chain simply ends after the local frames, and onlyexecution_scope = 'platform'raisesPLATFORM_DATABASE_NOT_REGISTERED.platform_database_id()itself is unchanged and still the canonical resolver.Also synced:
object-store.freeze_objectsrecursion (unnestskidsand joins on the(id, scope_id)PK, and the final UPDATE now matches onscope_idtoo), and thedatabase-jobstest now passesdb_id :=explicitly rather than settingjwt.claims.database_id.Two constructive-db test artifacts were not taken, because they are stale there and contradict the SQL both repos share: the
encrypted-secrets-tablesnapshot (uuid_generate_v4()vs. theuuidv7()the table actually defaults to) and the deletedinflection.dns_1123cases (the function still exists indeploy/).Validation
Against
constructiveio/postgres-plus:18:pnpm -r bundle— all 27 packages bundledpgpm test-packages --full-cycle— 27/27 modules deploy → verify → revert cleanobject-tree/object-store/inflection-db— all greenFollow-up (needs approval)
Nothing was published to npm, and no versions were bumped. Publishing (
lerna version+lerna publish from-package, which also regenerates thesql/*--<version>.sqlbundles anddefault_versionin the.control/Makefilefiles) is a separate step requiring explicit approval.Link to Devin session: https://app.devin.ai/sessions/8f10f72151e94c479e36f63ca4915f8e
Requested by: @pyramation