feat(app-scope): add routing_tables scoped table-name resolution#105
Merged
Conversation
Resolves the physical (schema, table) names of the scoped routing/site/ domain/route/app source and settings tables for a (database_id, scope) execution by walking app_scope.frames and joining the metaschema module registration tables; exact-scope frames win, then most-specific, per surface independently. Ported from constructive-db where it now lives in app_scope (moved out of metaschema_generators).
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstreams
app_scope.routing_tablesfrom constructive-db (landed there in constructive-io/constructive-db#2492), where it was moved out ofmetaschema_generatorsintoapp_scopebesideframes.routing_tables(database_id uuid, scope text)resolves the physical(schema, table)names of the scoped routing source/settings tables (apis + companions, sites + companions, domains/managed_domains, routes, apps +apps_key_column) for an execution at the given scope: it walksapp_scope.frames(database_id, scope)and joins themetaschema_modules_public.*_moduleregistration tables (api_surface_module,site_surface_module,domain_module,route_module,app_module), preferring an exact-scope frame then the most specific one — independently per surface. Thetable_id -> (schema, table)lookup is inlined as a join overmetaschema_public.table/schema(nometaschema-utilsdependency), raisingROUTING_TABLES_NOT_FOUNDnaming the offending module when a registration points at a missing table.Standard triple (deploy/verify/revert) + plan entry after
frames;pgpm-app-scope.controlalready requiredmetaschema-schema,metaschema-modules. Package tests green locally.Link to Devin session: https://app.devin.ai/sessions/45a8d63eb2f346efb8357dc6876f580c
Requested by: @pyramation