Dedupe runners for cli and server paths - #108
Open
bryantaustin13 wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on #105 (error-expecting test handling) — this branch is based on it and uses its responseIndicatesError/classification logic. Merge #105 first, then rebase this onto main so the diff shows only the dedup.
Extracts a single run-test-core (createExecutionContext + runTest) that both TestRunner (CLI) and TestExecutionService (server/MCP) now wrap, so a test scores identically regardless of entry point. Drops axios from the test path (fetch only), folds version-gating into the shared path so it also runs server-side, and normalizes skipMessage (removes the stray SkipMessage that dropped server skip reasons). Behavior-preserving: 0 status differences across 2035 tests CLI before/after, and 0 differences between CLI and server after.