Fix multiple object comprehension bugs - #358

Merged

stephenamar-db merged 22 commits into

databricks:masterfrom

JoshRosen:obj-comp-fixes

May 11, 2025

Commits on May 6, 2025

Add more test cases covering existing behaviors.
JoshRosen
committed
05ed13c
Add (failing) regression test for reported bug.
JoshRosen
committed
280b679
Fix reported bug.
JoshRosen
committed
2b76aeb
Add (failing) regression test for related prexisting bug for super refs.
JoshRosen
committed
64edef1
Fix related bug for super refs.
JoshRosen
committed
ee94db1
Add (failing) regression test for invalid obj comp key types.
JoshRosen
committed
7a281cb
Error on invalid obj comp key types.
JoshRosen
committed
856c193
Remove now-unused newSelf variable.
JoshRosen
committed
3239399
Add missing useNewEvaluator in eval.
JoshRosen
committed
1c51f11
Add regression test for another `super` bug.
JoshRosen
committed
55bcb26
Fix super in value calculations.
JoshRosen
committed
fd038d8
Simplify thunks / laziness in ValScope.extend() and Evaluator.visitBindings()
JoshRosen
committed
b74a493
remove one unnecessary local
JoshRosen
committed
fd3e9f4
scalafmt fixes
JoshRosen
committed
cb5593e

Commits on May 7, 2025

DRY up the error message.
JoshRosen
committed
bd4e1b2
See if inlining method avoids over-sensitivity in stack overflow test.
JoshRosen
committed
f5e40c2
Revert "See if inlining method avoids over-sensitivity in stack overflow test."
JoshRosen
committed
4867920
Revert "DRY up the error message."
JoshRosen
committed
63cad73
DRY up the error message.
JoshRosen
committed
7df617e
Support function definitions via object comprehensions.
JoshRosen
committed
e06e7a7
Hack to address CI flakiness.
JoshRosen
committed
5cd4ed8

Commits on May 8, 2025

Add comment calling out circular reference
JoshRosen
committed
0b2fce2