Add ignore js flag to format subcommand#2227
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
a29f0e3 to
1b5693c
Compare
|
/gcbrun |
hey so I'm not having any luck using test("shows help for 'format' command", async () => {
const result = await getProcessResult(execFile(nodePath, [cliEntryPointPath, "help", "format"]));
expect(result.exitCode).equals(0);
const output = result.stdout;
expect(output).to.include("Format the dataform project's files.");
expect(output).to.include("--check");
expect(output).to.include("Check if files are formatted correctly without modifying them.");
expect(output).to.include("--actions");`
expect(output).to.include("XXXXXXYYYYZZZZ");
// ^
// |
// +--- should fail since this won't be included in the output
});and then I do I get back a whole bunch of build failures but in particular I get back these lines I would expect 😅 I don't know anything about bazel so I'm just grepping and praying, reading the BUILD files in confusion and hoping for the best here the so I'm guessing bazel stuff changed but the docs didn't? |
Updated for latest changes (from #1349)
Allows users to only format
.sqlxfiles in case they use different formatters for js files.