Actualize nelm engine: extract NelmEngine with DI, add helm-render rule - #436
Closed
diyliv wants to merge 6 commits into
Closed
Actualize nelm engine: extract NelmEngine with DI, add helm-render rule#436diyliv wants to merge 6 commits into
diyliv wants to merge 6 commits into
Conversation
Signed-off-by: diyliv <onlogn081@gmail.com>
Signed-off-by: diyliv <onlogn081@gmail.com>
Signed-off-by: diyliv <onlogn081@gmail.com>
Signed-off-by: diyliv <onlogn081@gmail.com>
Signed-off-by: diyliv <onlogn081@gmail.com>
…linter registration Signed-off-by: diyliv <onlogn081@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the monolithic
internal/helm/render.gointo a pluggable NelmEngine following the d8-package-plugin architecture, and add a configurablehelm-renderrule to the templates linter.Changes
internal/helm/engine.goNelmEnginewith DI viaEngineOptionfunctional optionsinternal/helm/render.goRendererdelegates toNelmEngineinternallypkg/config.goHelmRenderRuleinTemplatesLinterRulespkg/config/linters_settings.gohelm-renderpkg/config/global/global.gointernal/module/module.govaluesfield +GetValues()+ config wiringinternal/module/helm_overrides.goHelmLibOverrides()for shared usepkg/linters/templates/rules/helm_render.goHelmRenderRulewithCheck()pkg/linters/templates/rules/helm_render_test.gopkg/linters/templates/templates.goArchitecture
Config
Verification
helm_render_test.gopassesgo vetclean on all affected packagesgo test ./internal/... ./pkg/...passes