cmd/prometheus: switch PROMPP_FEATURES defaults on (block-manager, instant-query, shrink-copier) - #439
Open
vporoshok wants to merge 2 commits into
Open
cmd/prometheus: switch PROMPP_FEATURES defaults on (block-manager, instant-query, shrink-copier)#439vporoshok wants to merge 2 commits into
vporoshok wants to merge 2 commits into
Conversation
…nt-query, shrink-copier) Flip several PROMPP_FEATURES defaults to their production-preferred state and provide inverse toggles instead of enable-only ones: - Block-manager historical storage is now the default; disable it with PROMPP_FEATURES=disable_block_manager (the enable_block_manager toggle is removed as redundant). The PP head manager + adapter remain the write path in both schemes; only the persisted-block reader changes. - Instant-query optimization is on by default; disable with PROMPP_FEATURES=disable_instant_query_feature. - Shrink shard copier is on by default; disable with PROMPP_FEATURES=disable_shrink_shard_copier. Also drop the disable_unload_data_storage toggle; DataStorage unloading stays enabled unconditionally (the pre-existing default). Co-authored-by: Cursor <cursoragent@cursor.com>
vporoshok
force-pushed
the
chore/block-manager-default
branch
from
July 22, 2026 17:19
90a02dc to
65378ac
Compare
The disable_unload_data_storage toggle was removed, so UnloadDataStorage is always true. Drop the variable and always use DefaultUnloadDataStorageInterval for DataStorage unloading. Co-authored-by: Cursor <cursoragent@cursor.com>
u-veles-a
approved these changes
Jul 23, 2026
vporoshok
enabled auto-merge (squash)
July 23, 2026 07:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flip several
PROMPP_FEATUREStoggles to their production-preferred defaults and replace the enable-only flags with inversedisable_*toggles.PROMPP_FEATURES=disable_block_manager(falls back to the pre-PR-377tsdb.DBreader). The redundantenable_block_managercase is removed. In both schemes the PP head manager + adapter remain the write path; only the persisted-block reader changes.PROMPP_FEATURES=disable_instant_query_feature.PROMPP_FEATURES=disable_shrink_shard_copier.disable_unload_data_storagetoggle.DataStorageunloading stays enabled unconditionally (the pre-existing default).Notes
CHANGELOG.mdchange here — per project convention the changelog is assembled at release time. These default flips should be captured in thev0.9.0release notes.Test plan
make build).PROMPP_FEATURES=disable_block_managerfalls back to the TSDB reader.disable_instant_query_feature/disable_shrink_shard_copierturn the respective features off.Made with Cursor