XSUP-73591: DBotFindSimilarIncidents script - fix broken incident hyperlinks - #45259
Conversation
lironcohen272
added
the
ready-for-ai-review
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
Coverage Report
|
||||||||||||||||||||||||||||||
marketplace-ai-reviewer
removed
the
ready-for-ai-review
|
🤖 Analysis started. Please wait for results... |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Hi! Thanks for your contribution to the DBotFindSimilarIncidents script. I've left a few notes primarily focused on optimizing performance. Specifically, evaluating the XSOAR version inside a DataFrame .apply() call adds unnecessary overhead per row, so I highly recommend using a factory function to check the version just once and updating the related calls and tests accordingly. Great work overall!
@kamalq97, @jlevypaloalto, @lironcohen272 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
lironcohen272
changed the title
This comment has been minimized.
This comment has been minimized.
kamalq97
left a comment
kamalq97
left a comment
There was a problem hiding this comment.
Looks good! Let's make sure all types of tenants are handled
lironcohen272
added
the
ready-for-pipeline-running
|
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
🔍 AI Triage Report AvailableAn automated triage report has been generated for this pipeline. Status:
|
4 participants
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-73591
Description
Issue:
The DBotFindSimilarIncidents script hardcoded legacy XSOAR 6 hash-based hyperlinks (id) for similar incident IDs, which are malformed on XSOAR 8.x and redirect analysts to the dashboard instead of the target incident.
Fix:
Added a create_incident_link helper that conditionally builds the URL based on the platform version (is_demisto_version_ge("8.4.0")), producing path-based links (/Details/id) on XSOAR 8.x and preserving legacy hash-based links (#/Details/id) on XSOAR 6.x.