[Xamarin.Build.Download] Prevent interactive 7-Zip extraction hangs#1506
Open
jonathanpeppers wants to merge 2 commits into
Open
[Xamarin.Build.Download] Prevent interactive 7-Zip extraction hangs#1506jonathanpeppers wants to merge 2 commits into
jonathanpeppers wants to merge 2 commits into
Conversation
Pass the documented -y switch so archive extraction cannot block waiting for overwrite confirmation, add regression coverage, and bump Xamarin.Build.Download to 0.11.5. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1d70ed1d-13b0-4ed9-b242-49fec179fa0f
There was a problem hiding this comment.
Pull request overview
This PR updates the Xamarin.Build.Download MSBuild task to ensure 7-Zip extraction cannot block indefinitely waiting for interactive overwrite confirmation (fixing #1047), adds regression coverage, and bumps the package version for release.
Changes:
- Add 7-Zip
-yswitch to force non-interactive extraction behavior on Windows. - Add a unit test asserting
-yis included in the generated 7-Zip arguments. - Bump Xamarin.Build.Download package version to 0.11.5.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| util/Xamarin.Build.Download/source/Xamarin.Build.Download/XamarinDownloadArchives.cs | Adds -y to 7-Zip extraction args to avoid interactive hangs. |
| util/Xamarin.Build.Download/source/Xamarin.Build.Download/Xamarin.Build.Download.csproj | Bumps NuGet package version to 0.11.5. |
| util/Xamarin.Build.Download/source/Xamarin.Build.Download.Tests/Test.cs | Adds regression test for non-interactive 7-Zip extraction arguments. |
Keep the dummy executable in the per-test temporary directory and report a clear failure if the reflected helper cannot be found. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1d70ed1d-13b0-4ed9-b242-49fec179fa0f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
-yswitch so extraction cannot wait indefinitely for overwrite confirmation.Fixes #1047