Implement within_fleets filter via entity_fleet_id#4062
Merged
Conversation
jvstme
approved these changes
Jul 23, 2026
| fleet_id = model.fleet_id | ||
| if fleet_id is None: | ||
| # Not-yet-flushed models may only have the fleet relationship set. | ||
| fleet = model.__dict__.get("fleet") |
Collaborator
There was a problem hiding this comment.
(nit) Isn't this equivalent to model.fleet?
>>> i = InstanceModel()
>>> i.__dict__.get("fleet") is None
True
>>> i.fleet is None
True
Collaborator
Author
There was a problem hiding this comment.
No, i.fleet may raise sqlalchemy.exc.MissingGreenlet if the attribute is not loaded. i.__dict__.get("fleet") would return None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show fleet events about deleted placeholder instances by using entity_fleet_id (see #4059 (comment)).