Add ContextWithMetadata to IntentResult - #2020
Open
julianna-ciq wants to merge 1 commit into
Open
Conversation
❌ Deploy Preview for fdc3 failed. Why did it fail? →
|
julianna-ciq
marked this pull request as ready for review
July 23, 2026 15:06
kriswest
requested changes
Jul 23, 2026
kriswest
left a comment
kriswest
left a comment
Contributor
There was a problem hiding this comment.
Apparently fixing this causing an example app to blow up as its expecting a type property on a non-void result (both channel and context have type). So a legitimate build fail apparently.
See the netlify build log: server-apps/security-demo-app1/src/app1.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ContextWithMetadatato the TypeScriptIntentResultunion.Why
The
IntentResultdocumentation explains that intent handlers may returnContextWithMetadata, but the documented and exported TypeScript union omitted it. This made the type declaration inconsistent with the supported handler result described immediately below it.Impact
TypeScript consumers can now use
ContextWithMetadataas anIntentResult, and the published API reference accurately reflects the union.Validation
npm test --workspace packages/fdc3-standard— 5 test files passed, 14 tests passed.git diff --check