Skip to content

fix keyboard_listener escape loop#6719

Open
OwenMcDonnell wants to merge 1 commit into
mainfrom
keyboard-listener-fix
Open

fix keyboard_listener escape loop#6719
OwenMcDonnell wants to merge 1 commit into
mainfrom
keyboard-listener-fix

Conversation

@OwenMcDonnell

@OwenMcDonnell OwenMcDonnell commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Description

Fix a bug with keyboard listener. Flutter sends a synthetic key up event for logical escape (command+.) on macOS which creates a loop as flet responds to the event.

Summary by Sourcery

Handle macOS Escape key events without creating a synthetic key-up loop in the keyboard listener.

Bug Fixes:

  • Prevent infinite event loops caused by Flutter's synthetic Escape key-up event for Command+Period on macOS.

Enhancements:

  • Route keyboard events through a Focus widget and introduce escape-specific handling to distinguish physical, synthetic, and Command+Period Escape events.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying flet-website-v2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: e53ace1
Status: ✅  Deploy successful!
Preview URL: https://a18c8a89.flet-website-v2.pages.dev
Branch Preview URL: https://keyboard-listener-fix.flet-website-v2.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant