test: cover 2xx webhook responses including 204 - #1358
Open
zanarellidev wants to merge 1 commit into
Open
Conversation
Clarify that the default HTTP response validator accepts any 2xx status, including 204 No Content, and add regression coverage so providers returning 204 cannot regress to a hard failure. Signed-off-by: zanarelli <zanarelli.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postMessageresponse validator already accepts any HTTP 2xx status (200 <= s < 300), including204 No Content.Fixes #441
Test plan
go test -count=1 -run Test_postMessage_accepts2xxStatusCodes ./internal/notifier/Test_postMessagestill passes