ci(subsystembenchmarks): harden stale VM cleanup - #983
Merged
zhixiangli merged 2 commits intoJul 23, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new cleanup-leaked-resources step in the Cloud Build configuration to automatically delete leaked VMs older than 10 hours before provisioning new ones. The review feedback suggests making the date parsing more robust by handling potential failures in date -d to prevent syntax errors during age calculation.
yuxin00j
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an automated preflight cleanup step in the subsystem benchmark Cloud Build workflow to delete leaked VM instances older than 10 hours.
Changes
cleanup-leaked-resourcesstep insubsystembenchmarks-cloudbuild.yamlthat queries Compute Engine for VMs matching${_INFRA_PREFIX}-vm-created more than 10 hours ago and deletes them.create-vmstep towaitFor: ["cleanup-leaked-resources"]to prevent VM quota exhaustion before attempting to create a new VM.