Skip to content

feat(subsystembenchmarks): print markdown result table - #984

Merged
zhixiangli merged 3 commits into
fsspec:mainfrom
zhixiangli:feat/subsystembenchmarks-markdown-report
Jul 23, 2026
Merged

feat(subsystembenchmarks): print markdown result table#984
zhixiangli merged 3 commits into
fsspec:mainfrom
zhixiangli:feat/subsystembenchmarks-markdown-report

Conversation

@zhixiangli

@zhixiangli zhixiangli commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Prints benchmark results as a Markdown table in shell output upon benchmark completion, improving immediate readability during CLI and Cloud Build runs.

Changes

  • Added print_csv_to_shell() helper in _common/report.py using PrettyTable with TableStyle.MARKDOWN.
  • Added prettytable==3.17.0 dependency to Hugging Face dataset requirements.
  • Updated run.py to print the formatted Markdown results table after benchmark completion and metric scraping.
  • Added upload log output in upload-results.sh.

@zhixiangli
zhixiangli requested a review from yuxin00j July 22, 2026 13:31

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds functionality to print generated CSV benchmark reports as Markdown tables in the shell using prettytable, and adds an upload progress message to the build script. The review feedback highlights that importing prettytable at the top level of the shared report.py module will cause ImportError crashes in benchmark environments where the dependency is not installed. To resolve this, the reviewer suggests importing prettytable locally inside print_csv_to_shell with graceful error handling, wrapping the CSV parsing in a try-except block to prevent benchmark run failures, and using row.get(header, "") to safely handle missing row values.

Comment thread gcsfs/tests/perf/subsystembenchmarks/_common/report.py Outdated
Comment thread gcsfs/tests/perf/subsystembenchmarks/_common/report.py
@zhixiangli
zhixiangli merged commit c894ac3 into fsspec:main Jul 23, 2026
9 checks passed
@zhixiangli
zhixiangli deleted the feat/subsystembenchmarks-markdown-report branch July 23, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants