Skip to content

ci: Increase macrobenchmark JobSet timeout for FSDP strategies - #987

Closed
yuxin00j wants to merge 3 commits into
fsspec:mainfrom
yuxin00j:fix-fsdp-timeout
Closed

ci: Increase macrobenchmark JobSet timeout for FSDP strategies#987
yuxin00j wants to merge 3 commits into
fsspec:mainfrom
yuxin00j:fix-fsdp-timeout

Conversation

@yuxin00j

Copy link
Copy Markdown
Collaborator

This increases the wait_for_jobset polling limit in lib.sh from 2 hours to 4 hours specifically for fsdp_full and fsdp_sharded runs.

We observed that FSDP runs were frequently exceeding the default 2-hour timeout, causing scrape_metrics.sh to exit without uploading the partial CSV metrics to the results bucket. The overall Cloud Build limit of 6 hours safely accommodates this new 4-hour limit.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the wait_for_jobset function in cloudbuild/macrobenchmarks/scripts/lib.sh to dynamically increase the maximum polling iterations from 240 to 480 when the training strategy is fsdp_full or fsdp_sharded. The reviewer noted that applying this extended timeout to the seed-checkpoint step is risky because it could cause the build to hang for too long and exceed the overall Cloud Build limit, thereby skipping critical cleanup steps. It is recommended to restrict this timeout increase specifically to the run-workload step.

Comment thread cloudbuild/macrobenchmarks/scripts/lib.sh
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (e6c107b) to head (f230d57).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #987   +/-   ##
=======================================
  Coverage   89.68%   89.68%           
=======================================
  Files          16       16           
  Lines        3579     3579           
=======================================
  Hits         3210     3210           
  Misses        369      369           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yuxin00j
yuxin00j requested a review from zhixiangli July 24, 2026 05:58
@yuxin00j yuxin00j closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant