Skip to content

Introduce callback functions for printing in lemke.py #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahulsavani merged 10 commits into from
Jul 31, 2026
Merged

Introduce callback functions for printing in lemke.py #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b0e8b86
Separate runlemke() from tableau class
nataliemes Jun 9, 2026
3de14b7
Remove printout() calls outside runlemke()
nataliemes Jun 16, 2026
3167636
Separate docupivot(), outsol(), outstatistics() from tableau class
nataliemes Jun 16, 2026
945bc47
Add callback functions
nataliemes Jun 16, 2026
9d26088
Merge branch 'main' into refactor/callbacks-lemke
nataliemes Jul 24, 2026
a3c76db
Update test_lemke.py
nataliemes Jul 24, 2026
4ab1cec
CLI exit code 1 when no solution found
nataliemes Jul 24, 2026
d7a2659
Raise error in bimatrix if runlemke() finds no solution
nataliemes Jul 24, 2026
6681835
Merge branch 'main' into refactor/callbacks-lemke
nataliemes Jul 30, 2026
1533fc4
Update a test docstring
nataliemes Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions src/lemke/bimatrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,14 @@ def createLCP(self):
def runLH(self, droppedlabel):
lcp = self.createLCP()
lcp.d[droppedlabel - 1] = 0 # subsidize this label
tabl = lemke.tableau(lcp)
# tabl.runlemke(verbose=True, lexstats=True, z0=gz0)
tabl.runlemke()
return tuple(getequil(tabl))

result = lemke.runlemke(lcp=lcp)
if result is None:
raise RuntimeError("runlemke() failed to find a solution unexpectedly.")

equilibrium = result[1: lcp.n - 1]
return tuple(equilibrium)
Comment on lines 157 to +167

@rahulsavani rahulsavani Jul 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nataliemes This is not a problem because LH should never fail with ray termination, do you agree?

@nataliemes nataliemes Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, runlemke() should never fail here, but I added an explicit check anyway, so that if it ever does (due to a bug in our implementation), the error is clearer.


def LH(self, LHstring):
m = self.A.numrows
Expand All @@ -184,9 +188,13 @@ def runtrace(self, xprior, yprior):
Ay = self.A.negmatrix @ yprior
xB = xprior @ self.B.negmatrix
lcp.d = np.hstack((Ay, xB, [1, 1]))
tabl = lemke.tableau(lcp)
tabl.runlemke()
return tuple(getequil(tabl))

result = lemke.runlemke(lcp=lcp)
if result is None:
raise RuntimeError("runlemke() failed to find a solution unexpectedly.")

equilibrium = result[1: lcp.n - 1]
return tuple(equilibrium)

def trace_uniform_prior(self):
m = self.A.numrows
Expand Down Expand Up @@ -255,11 +263,6 @@ def uniform(n):
return np.array([fractions.Fraction(1, n) for _ in range(n)])


def getequil(tabl):
tabl.createsol()
return tabl.solution[1: tabl.n - 1]


def str_eq(eq, m, n):
x = "(" + ",".join([str(x) for x in eq[0:m]]) + ")"
y = "(" + ",".join([str(x) for x in eq[m: m + n]]) + ")"
Expand Down
Loading
Loading