feat(core): [Data Collection 1] Add configuration types#5760
Draft
adinauer wants to merge 2 commits into
Draft
Conversation
Add the public Data Collection model, key-value collection behavior, and HTTP body direction types. Preserve unset values internally so the resolver can distinguish legacy bridge mode from explicit configuration. Refs #5666 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
Avoid coupling the Data Collection configuration test to reference identity. The test only needs to verify that setting a nested header behavior marks the configuration explicit. Refs #5666 Co-Authored-By: Claude <noreply@anthropic.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Data Collection)
📜 Description
Add the foundational public types for configuring automatic data collection:
DataCollection, with nullable raw overrides and nested HTTP-header and GraphQL settingsKeyValueCollectionBehavior, with mutually exclusive off, deny-list, and allow-list modesHttpBodyType, covering the four specification-defined HTTP directionsThe public
DataCollection()constructor represents an explicit object, including an explicit empty configuration. A package-private constructor supports the unconfigured instance thatSentryOptionswill own in the next stack PR. Mutable collection inputs are copied and exposed as immutable values.This PR intentionally does not expose the model through
SentryOptionsor change runtime collection behavior.💡 Motivation and Context
Establish the Java-shaped configuration model required by the Data Collection specification before adding resolution, configuration sources, and integration enforcement. Nullable raw values preserve the distinction between omitted values and explicit false or empty values.
Refs #5666
💚 How did you test it?
./gradlew spotlessApply apiDump./gradlew :sentry:check📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Add the always-present
DataCollectioninstance and resolver toSentryOptions, then wire external configuration and integrations in subsequent stack PRs.#skip-changelog