Centralise lockdown author checks#2881
Open
kerobbi wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes lockdown author verification for issue and pull-request reads, failing closed when authors cannot be verified.
Changes:
- Added a shared lockdown decision helper and restriction messages.
- Routed issue and pull-request retrieval through the helper.
- Added helper and pull-request lockdown tests.
Show a summary per file
| File | Description |
|---|---|
pkg/github/lockdown.go |
Adds shared author lockdown logic. |
pkg/github/lockdown_test.go |
Tests missing-cache and empty-author handling. |
pkg/github/issues.go |
Uses the shared helper for issue reads. |
pkg/github/pullrequests.go |
Uses the shared helper for pull-request reads. |
pkg/github/pullrequests_test.go |
Adds lockdown allow/deny cases. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Medium
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts a single shared helper for lockdown mode author checks and routes
GetIssueandGetPullRequestthrough it, failing closed when the author can't be verified.Why
Part of https://github.com/github/copilot-mcp-core/issues/1798
What changed
authorLockdownResult(pkg/github/lockdown.go) - one place that resolves the lockdown decision for content authored by a given login, with shared restriction messages - and routedGetIssueandGetPullRequestthrough it.GetPullRequest's error path to a tool-result error to matchGetIssue.GetPullRequest.MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
Lint & tests
./script/lint./script/testDocs