fix: set DestructiveHint to false for notification subscription tools#2884
Open
srpatcha wants to merge 1 commit into
Open
fix: set DestructiveHint to false for notification subscription tools#2884srpatcha wants to merge 1 commit into
srpatcha wants to merge 1 commit into
Conversation
Under MCP schema 2025-06-18, an omitted DestructiveHint defaults to true. Both manage_notification_subscription and manage_repository_notification_subscription only modify the caller's own subscription preferences, not thread or repository content, so they should be marked non-destructive. Explicitly set DestructiveHint: false to match the existing pattern used by other non-destructive write tools (e.g., issue tools in issues_granular.go). Fixes github#2841 Signed-off-by: Srikanth Patchava <srpatcha@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Under MCP schema 2025-06-18, an omitted
DestructiveHintdefaults totrue. Bothmanage_notification_subscriptionandmanage_repository_notification_subscriptiononly modify the caller's own subscription preferences — they do not modify thread or repository content — so they should be marked non-destructive.Changes
Annotations: &mcp.ToolAnnotations{ - Title: t("TOOL_MANAGE_NOTIFICATION_SUBSCRIPTION_USER_TITLE", ...), - ReadOnlyHint: false, + Title: t("TOOL_MANAGE_NOTIFICATION_SUBSCRIPTION_USER_TITLE", ...), + ReadOnlyHint: false, + DestructiveHint: jsonschema.Ptr(false), },Same change applied to both
ManageNotificationSubscriptionandManageRepositoryNotificationSubscriptioninpkg/github/notifications.go.This follows the existing pattern used by other non-destructive write tools like the issue tools in
pkg/github/issues_granular.go.Fixes #2841