Refactor unzip functionality to limit concurrency and improve error handling in copyStream#4455
Draft
shati-patel wants to merge 3 commits into
Draft
Refactor unzip functionality to limit concurrency and improve error handling in copyStream#4455shati-patel wants to merge 3 commits into
copyStream#4455shati-patel wants to merge 3 commits into
Conversation
Contributor
|
Great start @shati-patel . I've pushed a commit to also add timeouts, in case something goes wrong with the writing. That will give us an extra layer or protection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4453
Discussed with @josefs and tried various other fixes locally (like limiting the number of available cores). Eventually settled on this change to
copyStream.I installed the dev VSIX build locally and can confirm that the extraction now works smoothly 🎉
Note: this still needs a changelog note and potentially some tidy-up